Skip to content

Make react and preact peerDependencies both optional - #140

Merged
developit merged 1 commit into
masterfrom
optional-peer-deps
Mar 1, 2019
Merged

developit merged 1 commit into
masterfrom
optional-peer-deps

Conversation

@developit

Copy link
Copy Markdown
Owner

This avoids misleading npm warnings. Fixes #139.
/cc @Timer @NathanielHill

@NathanielHill

Copy link
Copy Markdown

Awesome thanks. I believe this effects everyone using Next, so a big win to remove these errors 👍

@developit
developit merged commit c7f69af into master Mar 1, 2019
@jamesreggio

Copy link
Copy Markdown

@developit — do you mind cutting a release? I see you landed a handful of PRs about a week ago, so it might be a good time to bundle them up.

@developit

developit commented Mar 10, 2019 •

Copy link
Copy Markdown
Owner Author

@jamesreggio yup, sorry about that - release is out now, I took some time to add support for preact X and fixed a couple issues in the react integration.

@developit
developit deleted the optional-peer-deps branch March 10, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants